[BUG] Power Loss Recovery doesn't works

Desuuuu / Marlin

Optimized firmware for RepRap 3D printers based on the Arduino platform. Modified with a new DWIN T5UID1 touchscreen implementation.

GNU General Public License v3.0

31 stars 10 forks source link

[BUG] Power Loss Recovery doesn't works #16

Closed mrv96 closed 3 years ago

mrv96 commented 3 years ago

Hi Desuuu, I know that you merged your repo with Marlin 2.0.7.2 after a my request. Today I was trying the power loss feature, but it doesn't work. I found that unluckily the PLR feature is broken in Marlin 2.0.7.2, but it has been already fixed in the bugfix branch.

I open this issue as reminder to merge next Marlin release in your repo asap.

P.S: a PR of your excellent work in official Marlin would avoid this kind of situations ☺

P.S: there is a lot of hidden developement behind your repo, I'm developing it for the whole Longer LKx Pro italian community, but i know of works based on this repo also in France. Thank you very much!

Astador commented 3 years ago

Hi @mrv96 Any luck with this?? i'm trying to use PLR feature but get stuck after reach last point printed. did you resolve the issue?

mrv96 commented 3 years ago

Hi, here the list of possible solutions:

Wait for next Marlin release
Substitute powerloss.cpp and powerloss.cpp of this repo with the ones in the current official Marlin bugfix branch (not tested)
Substitute powerloss.cpp and powerloss.cpp of this repo with the ones in Marlin 2.0.6.1 (working)
Apply this https://github.com/bigtreetech/BIGTREETECH-SKR-mini-E3/issues/444#issuecomment-748154694 (working)

Desuuuu commented 3 years ago

The bugfix branch now has my modifications applied to Marlin's bugfix-2.0.x branch, so it should contain the fix for this issue.

As a side note, I also removed the 2.0.7.2 release as it was causing too many issues.

mrv96 commented 3 years ago

Marlin 2.0.8 has been just released: https://github.com/MarlinFirmware/Marlin/releases/tag/2.0.8