search

Desuuuu / Marlin

Optimized firmware for RepRap 3D printers based on the Arduino platform. Modified with a new DWIN T5UID1 touchscreen implementation.
GNU General Public License v3.0
31 stars 10 forks source link

Spaces in GCode input and steppers not off when print aborted. #24

Closed DaKrampus closed 3 years ago

DaKrampus commented 3 years ago

First of all Desuuuu, i want to stress that this firmware works like a charm on a CR10Spro. I had lots of problems with the TM firmware, but this one is great. There are 2 features I would love to see though, but i do not know how easy/difficult they are to implement.

  1. I know that spaces are not necessary in Gcode. But if you have a code with 4 parameters you want to input, it is so much easier if you can input a space between the parameters. but i agree it works without it.

  2. Its certainly not a bug, because TM also does it that way, even at the end of a print. Head parks with steppers OFF, but when you click (press) done (or finish print) the steppers are ON again, which i find annoying, because you want to pull the plate towards you again and maybe clean it, for the next print... In your version it is perfect, because the steppers remain off like it is expected by me.

But if you ABORT a print, the nozzle parks itself and the steppers remain ON. To be able to move the build plate etc... i have to stop them manually. I can live with that, but it would be nice if they behaved like at the end of a print. ==> steppers OFF.

Thats my 2 cents.

But if i may, i think the overall utility of this firmware is far superior to the Stock AND to the TM one. I am really happy with this one, and must say it gives me a much better feeling when printing. I have the impression i have a better control over my printer with this firmware.

Thanks again for your great work

Luc

Desuuuu commented 3 years ago

I know that spaces are not necessary in Gcode. But if you have a code with 4 parameters you want to input, it is so much easier if you can input a space between the parameters. but i agree it works without it.

I already plan on remaking the keyboard. Thing is, I also plan on completely refactoring the firmware (into something more flexible), so I'm not sure I wanna invest time into updating the keyboard before that.

if you ABORT a print, the nozzle parks itself and the steppers remain ON

That's the expected behaviour with the default configuration.

You can change the EVENT_GCODE_SD_ABORT option in Configuration_adv.h if you want to change this.

DaKrampus commented 3 years ago

You can change the EVENT_GCODE_SD_ABORT option in Configuration_adv.h if you want to change this.

Thank you i will .. great! Dont worry for the keyboard, it is not something you use very often.. (at least I dont) just once in while... thanx again.

Luc