search

Desuuuu / Marlin

Optimized firmware for RepRap 3D printers based on the Arduino platform. Modified with a new DWIN T5UID1 touchscreen implementation.
GNU General Public License v3.0
31 stars 10 forks source link

[FR] Allow a custom size ABL grid #6

Closed mrv96 closed 3 years ago

mrv96 commented 3 years ago

According to this line of code:

https://github.com/Desuuuu/Marlin/blob/1b614d3e4a0ae117b86b86dd30e2cfe3ac32baaa/Marlin/src/lcd/extui/lib/dgus_reloaded/config/DGUS_Constants.h#L28

ABL grid size must be composed exactly of 25 points. Why this limitation? Is there any way to remove it?

Desuuuu commented 3 years ago

The two ABL screens (1 and 2) expect a 5x5 grid. I don't think there's a way to have a proper UI with a variable grid size, hence why it's fixed.

It's possible to make it work with different grids regardless but the UI will be broken and that's something I don't really like.

mrv96 commented 3 years ago

Thank you for your reply. In order to have a huge grid the steps to performs are only:

Am i missing something?

Desuuuu commented 3 years ago

That sounds about right.

In case you need new addresses for the screen, make sure you use new ones to avoid any issue.

mrv96 commented 3 years ago

Thank you. Since this feature request cannot be solved, I close the issue.

mrv96 commented 3 years ago

@Desuuuu what about loading circle instead of fixed on-screen grid during ABL procedure?

Desuuuu commented 3 years ago

That's always an option, but both the probing & automatic leveling screens would need to be modified for it. The best way to do it would probably to make variants of these screens so the current functionality would be preserved for 5x5 grids.

I'm not going to be able to dedicate much time to this for at least a few month though.

I'll reopen this ticket anyway, as that would be a nice feature to have and there should be a proper way to implement it.