Desuuuu / klipper

Klipper is a 3d-printer firmware. Modified to work with DWIN T5UID1 touchscreens.
GNU General Public License v3.0
124 stars 51 forks source link

Correct the variable addresses for Filename and M117 messages #140

Closed Thinkersbluff closed 1 year ago

Thinkersbluff commented 1 year ago

Per the T5L Application Development Guide (page 150, section 7.16.2 Software setting, Scroll Text widget):

"The first three bytes of the text pointer must be reserved. The text content displayed by the user is stored from (VP+3)"

Both [t5uid1_var file_name} and [t5uid1_var message] are implemented as scrolling text widgets, in the DWIN_SET application, so both are impacted by this limitation, which I did not notice before now.

I have made the Filename variable as large as t5uid1 permits (32 characters) I have shortened the Message variable to the max text displayable without scrolling (26 characters), which effectively means I did not need to use a scrolling text widget. I will not change all of those back to a Text widget, but it is hard to watch a screen with two scrolling fields on it and I am gambling that there are no messages longer than 26 characters to be displayed. In future iterations, this can be revisited, for cause...