fix values with a type annotation that were narrowed to `Never` being coloured as a type

DetachHead / basedpyright

pyright fork with various type checking improvements, improved vscode support and pylance features built into the language server

https://docs.basedpyright.com

Other

1.02k stars 19 forks source link

fix values with a type annotation that were narrowed to `Never` being coloured as a type #401

Closed DetachHead closed 3 months ago

DetachHead commented 3 months ago

broken in a92ab39568d95e44d7e1366440a2ff6c71c2480b

fixes #398

github-actions[bot] commented 3 months ago

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

ValdezFOmar commented 3 months ago

@DetachHead I can confirm that it works. Not necessarily related to the original issue but I found that it doesn't account for 3.12 aliases, though other aliases work fine:

DetachHead commented 3 months ago

thanks! i raised #402 for this. will try to fix that in a follow-up PR since it looks like that was already broken