DetachHead / basedpyright

pyright fork with various type checking improvements, improved vscode support and pylance features built into the language server
http://docs.basedpyright.com/
Other
601 stars 12 forks source link

`basedpyright.analysis.diagnosticSeverityOverrides` does not work in vscode's `settings.json` #418

Closed DetachHead closed 1 week ago

DetachHead commented 2 weeks ago

upstream issue in pyright. works fine in pylance

{
  "basedpyright.analysis.diagnosticSeverityOverrides": {
    "reportAttributeAccessIssue":false,
    "reportUnusedVariable": false,
    "reportDeprecated": false
  },
}
foo = 1
foo.asdfasdf # error: reportAttributeAccessIssue
DetachHead commented 2 weeks ago

ffs wrong repo

willofferfit commented 1 week ago

If it's an upstream issue, was an issue already opened in https://github.com/microsoft/pyright/ to report this?

DetachHead commented 1 week ago

feel free to raise it yourself if you want. i stopped raising issues upstream after receiving this response

willofferfit commented 1 week ago

Wow I'd have stopped too. Do you have more details about the bug that I could include in the bug report?

andryandrew commented 1 week ago

This seems relevant: https://github.com/DetachHead/basedpyright/issues/387

DetachHead commented 1 week ago

upstream the setting is called python.analysis.diagnosticSeverityOverrides and it only happens on the pyright vscode extension, but not pylance. i think it may be a regression from a recent release but i don't know for sure.

DetachHead commented 1 week ago

Duplicate of #387