Closed DetachHead closed 2 weeks ago
after looking at how ruff does it, i decided this approach sucks. instead we should add support for typechecking notebooks in the CLI and add support for them in the LSP itself, rather than trying to do it the pylance way
fixes #173
stuff to address before merging:
PYLANCE_EXTENSION_ID
to"detachhead.basedpyright"
. if this is the only change we need to make it would be a pain if we had to fork and publish our own version just for that, maybe there's a way we can hack the official extension at runtime?"basedpyright.importStrategy": "fromEnvironment"
). i don't know enough about the development workflow of jupyter notebooks users to know if this is a problem or not. (ie. is type checking notebooks in CI a thing?)