search

DetachHead / basedpyright

pyright fork with various type checking improvements, improved vscode support and pylance features built into the language server
https://docs.basedpyright.com
Other
1.08k stars 19 forks source link

PyCharm plugin and LSP settings #801

Open InSyncWithFoo opened 4 hours ago

InSyncWithFoo commented 4 hours ago

I see that you are recommending my plugin as "the" PyCharm plugin for basedpyright (thanks for that). There's one problem with this: LSP settings will not be sent in the way the user expects.

According to the docs, basedpyright respects settings in the basedpyright object rather than Pyright's pyright. However, the plugin only maps UI settings to pyright.* properties. This might cause some confusion.

Maintaining settings parity with basedpyright is something I'd rather not do, at least not on my own. In fact, I don't intend to add any new features at all and will probably only do bugfixes as necessary. It is thus perhaps better for you to fork the plugin and publish the fork as a new one; that is something I can help with as a reviewer.

DetachHead commented 3 hours ago

thanks for letting me know. i linked to your extension because i noticed it has logic to detect either the pyright or basedpyright executable so i assumed it would work with both.

i agree having a separate fork of the extension for basedpyright is probably the way to go