self and cls semantic highlighting

[Kajiih]

Hi, thanks for your great work !

I'm not very familiar with the topic, but in methods and class methods, self and cls are semantically considered as regular parameters in basedpyright (as opposed to Pylance).

Pylance:


basepyright:


So in VS Code at least, the specific highlighting is overridden by the semantic highlighting of parameters, which I think is pretty sad 😢

Also, I'm not sure if it is linked, but in the playground, self and cls are highlighted differently:

playground:

While we are at it, we can also notice a difference in how the decorators are interpreted, classmethod and absractmethod are considered as functions in basedpyright but class in Pylance. I'm not sure which one is the most logical or if it's a feature, but the basedpyright way seems the most natural to me.

[DetachHead]

Also, I'm not sure if it is linked, but in the playground, self and cls are highlighted differently:

the playground only has syntax highlighting which isn't handled by basedpyright but rather the monaco editor that it uses

While we are at it, we can also notice a difference in how the decorators are interpreted, classmethod and absractmethod are considered as functions in basedpyright but class in Pylance. I'm not sure which one is the most logical or if it's a feature, but the basedpyright way seems the most natural to me.

yeah this was intentional and was implemented by @ValdezFOmar in #217

[Kajiih]

Thanks for the clarification!