Detailing-the-Realm / svnsea2e

Foundry VTT 7th Sea Second Edition System (Unofficial)
MIT License
10 stars 13 forks source link

probleme with roll dice for vilain #114

Closed ZolOnTheNet closed 1 year ago

ZolOnTheNet commented 2 years ago

I have a problem when a want to roll vilain's influence or strength : a js error due to a lack of value userForMe and UserForHelpMe input box. I don't know if you are same error (foundryvtt v10.284) error 1 : Uncaught (in promise) TypeError: form.useForMe is undefined _spendHeroPoint roll.js:83

error 2 : Uncaught (in promise) TypeError: form.useForHelpMe is undefined _calculBonusDice roll.js:71

a solve the problem with add in trail-roll-dialog.html

<input type="hidden" id="useForMe" name="useForMe" value="0" / > <input type="hidden" id="useForHelpMe" name="useForMe" value="0" / >

I knows is not elegant but it's work for now... Normaly you need to more protect then test of useForMe (line 83) and useForHelpMe (lien 71) but i learn javascript and i don't know to do that a this time...

thank for you job ! ps: i'm not fluent english..., sorry for that so...

Thomas-Maurer commented 2 years ago

This was fixed in : https://github.com/Detailing-the-Realm/svnsea2e/pull/107 If you use the latest version you should be good to go :D

Armaklan commented 1 year ago

Resolve in #107