Detanup01 / gbe_fork

Fork of https://gitlab.com/Mr_Goldberg/goldberg_emulator
https://gitlab.com/Mr_Goldberg/goldberg_emulator
GNU Lesser General Public License v3.0
221 stars 47 forks source link

Fixes for `Steam_Http` class #10

Closed otavepto closed 2 months ago

otavepto commented 2 months ago

As far as I can remember, this won't work with Github

  1. The deps cache you currently have is built without mbedtls
  2. If you invalidated the cache (deleting it), you'll have to first integrate the PR otherwise you'll build again with the old stuff
  3. If you delete the cache and trigger the checks on the PR again, Github will create a separate cache for this PR, but it will invalid once it is integrated, but at least it will be valid
  4. In any case if this PR is integrated, the current cache has to be deleted and rebuilt again

I assume there might be a better way to handle this scenario but I just don't know how. If you decided to integrate this PR, and it broke, you can ping me here and I'll see what broke and how to fix it.

You can test this with appid 1902490 (free game) since it downloads its own app schema via https protocol.

Feel free to close/reject this PR if it's too much trouble.

Detanup01 commented 2 months ago

I merge this and #12 . Thanks all of you!

thecatontheceiling commented 2 months ago

@otavepto why did you delete your fork if you are willing to work on it further?

otavepto commented 2 months ago

@otavepto why did you delete your fork if you are willing to work on it further?

my apologies to you, will never contribute here again