search

DeterminateSystems / nix-installer-action

The Github Action for the Determinate Nix Installer
https://github.com/determinateSystems/nix-installer
GNU Lesser General Public License v2.1
158 stars 16 forks source link

`$HOME/.nix-profile/bin` not in PATH #21

Closed lovesegfault closed 1 year ago

lovesegfault commented 1 year ago

This causes cachix-action to fail when using Nix 2.15: https://github.com/cachix/cachix-action/issues/146

I think echo "$HOME/.nix-profile/bin" >> "$GITHUB_PATH" is warranted somewhere, though I am uncertain whether that should happen here or in the installer.

lovesegfault commented 1 year ago

Ah, it's this issue: https://github.com/DeterminateSystems/nix-installer/issues/475

Note, however, that this line here would also need updating: https://github.com/DeterminateSystems/nix-installer-action/blob/9b252454a8d70586c4ee7f163bf4bb1e9de3d763/action.yml#LL121C5-L121C5

lovesegfault commented 1 year ago

This issue isn't resolved yet, I tried bumping to v3 and removing my workaround in this commit: https://github.com/lovesegfault/nix-config/commit/68886670c7cb253b07d4f967df871251cca57d2b

But the issue persisted, and the build failed: https://github.com/lovesegfault/nix-config/actions/runs/5101945610/jobs/9171171410

Hoverbear commented 1 year ago

We determined https://github.com/DeterminateSystems/nix-installer/pull/482 was required as well, I'll be releasing it Tuesday (https://github.com/DeterminateSystems/nix-installer/pull/484) since most folks are out today on various holidays.

lovesegfault commented 1 year ago

Removed my workaround and the build still works!

I did need to explicitly use nix-installer-tag: "v0.9.1"; otherwise it picked up the 0.8 release.

Thanks!

Hoverbear commented 1 year ago

Great!