search

DeterminateSystems / nuenv

A Nushell environment for Nix
https://determinate.systems
MIT License
189 stars 13 forks source link

Dead code in build.nu #2

Closed matklad closed 1 year ago

matklad commented 1 year ago

First time reading nu code, so I might be asking a dumb question here, but isn’t this whole if a no-op?

https://github.com/DeterminateSystems/nuenv/blob/bf5a203980baff4c2bda2344339deb9fecc149ab/nuenv/builder.nu#L69

It seems that it prints stuff, but doesn’t actually add it to PATH?

lucperkins commented 1 year ago

@matklad That's actually intended to be a no-op and solely for logging purposes. The full set of packages that will be added to the PATH is determined here while the PATH is set here.

lucperkins commented 1 year ago

@matklad I did make a few inline docs changes that will hopefully make that more clear!