search

DeterminateSystems / riff

Riff automatically provides external dependencies for Rust projects, with support for other languages coming soon.
https://riff.sh
Mozilla Public License 2.0
486 stars 13 forks source link

Workspace support? #156

Open RaitoBezarius opened 2 years ago

RaitoBezarius commented 2 years ago

Is riff supposed to support Cargo workspace or does it have any plan to do so?

cole-h commented 2 years ago

Do you have an example repository that uses Cargo workspaces where riff doesn't work well? I think it should work fine in workspaces and non-workspaces alike, but maybe that's not the case (and no project immediately comes to mind that I could test with and verify).

RaitoBezarius commented 2 years ago

I tested it on a private monorepo project, alas, so I cannot share it.

What happened is there is no Cargo.toml at the root but it seems like there was some sort .cargo/Cargo.toml in the monorepo linking to each of the sub-projects. riff was working fine in the sub-project, but not really at the root.

I will see if I can create a reproducer but I was more like: let's see how magic this is — so I need some time to ascertain what happened exactly.

cole-h commented 2 years ago

I can't reproduce the issue. Maybe that repo is using some non-standard method of defining a workspace? Could you post the error output (or DM it to me on Matrix: @cole-h:matrix.org)? I tested with https://github.com/alacritty/alacritty and https://github.com/zellij-org/zellij, both of which use Cargo workspaces, and they seemed to build just fine for me.