DeterminateSystems / riff

Riff automatically provides external dependencies for Rust projects, with support for other languages coming soon.
https://riff.sh
Mozilla Public License 2.0
486 stars 13 forks source link

treewide: fsm -> riff inside code -- DS-280 #69

Closed cole-h closed 2 years ago

cole-h commented 2 years ago

Draft, because I'd like https://github.com/DeterminateSystems/riff/pull/58 to merge first (and I'll rebase on that) to prevent making more work for others.

linear[bot] commented 2 years ago
DS-276 Rename to `riff`

Any user-presenting references to `fsm` should be changed to `riff`. Bonus points for updating the code to match.

DS-280 Rename code references to `riff` as well

But after everything in-flight is done / merged, so as to reduce merge conflicts.

Hoverbear commented 2 years ago

Noting this requires some changes on the registry:

❯ riff run ls
✓ 🦀 rust: cargo, openssl, pkg-config, rustc, rustfmt
  2022-08-30T17:05:06.987170Z ERROR riff::dependency_registry: Could not parse new registry data from https://riff-registry.fly.dev/riff-registry.json, err: EOF while parsing a value at line 1 column 0
    at src/dependency_registry/mod.rs:104

Cargo.lock  Cargo.toml  LICENSE  README.md  dev-env  flake.lock  flake.nix  img  nix  registry  result  result-man  src  target
Hoverbear commented 2 years ago

Nice PR!

I managed to catch one you might have missed in a merge:

❯ rg fsm
src/dependency_registry/mod.rs
27:        "Reading cached registry (Maybe you need to remove `$XDG_CACHE_DIR/fsm/registry.json`?)"
grahamc commented 2 years ago

regarding the registry update: I fixed that issue by deploying the current registry code :).