Open peterbecich opened 1 month ago
Thanks for this great GitHub Action. I haven't tested it yet.
What happens if flake update fails? Will the PR still be created?
flake update
An example is the hackage-server flake.nix. Right now, nix flake update will fail because the Flake is incompatible with current NixPkgs.
hackage-server
flake.nix
nix flake update
Additionally, building on https://github.com/DeterminateSystems/update-flake-lock/issues/91, can additional checks be specified that would prevent the PR from being created?
Assuming the PR is created regardless of flake update success or failure, a broken flake.nix can be caught by other GitHub Action tests on the flake. However, there may be a lot of automated and broken PRs sitting in the list.
flake
automated
I think I've answered my own question; no:
https://github.com/DeterminateSystems/update-flake-lock/blob/db4ee38117a597ea8df8f7f75a187dd65093eade/src/index.ts#L65
Thanks for this great GitHub Action. I haven't tested it yet.
What happens if
flake update
fails? Will the PR still be created?An example is the
hackage-server
flake.nix
. Right now,nix flake update
will fail because the Flake is incompatible with current NixPkgs.Additionally, building on https://github.com/DeterminateSystems/update-flake-lock/issues/91, can additional checks be specified that would prevent the PR from being created?
Assuming the PR is created regardless of
flake update
success or failure, a brokenflake.nix
can be caught by other GitHub Action tests on theflake
. However, there may be a lot ofautomated
and broken PRs sitting in the list.