search

DethAriel / ng-recaptcha

Angular component for Google reCAPTCHA
https://dethariel.github.io/ng-recaptcha/
MIT License
463 stars 122 forks source link

Update to Angular v17 #311

Closed medbenmakhlouf closed 7 months ago

medbenmakhlouf commented 7 months ago

@DethAriel , would you mind to take a look ? Thanks

Matrix89 commented 7 months ago

I think you missed the compatibility info in the readme

bsplosion commented 7 months ago

I think you missed the compatibility info in the readme

Edit I think I may have misunderstood the comment from @Matrix89 - this PR didn't update the readme yet and should since it ostensibly adds compatibility. My apologies!

Old response for posterity of my mistake:

Pretty sure they understand the compatibility info in the readme - it clearly states compatibility for versions through 16.x.x (for ng-recaptcha@12.x.x). It also states that "Starting with ng-recaptcha@7, only one version of Angular will be supported". This clearly indicates that for Angular 17.x.x compatibility there are changes required, hence the ticket.

DethAriel commented 7 months ago

Thx for the PR @medbenmakhlouf . Let me take care of it

DethAriel commented 7 months ago

I merged this via cherry-picking from your pull request. I did squash some commits, and modified the commit messages. Thank you for your contribution @medbenmakhlouf !

carriquiry-g commented 7 months ago

@DethAriel when are you planning on releasing the v13 update?