search

DethAriel / ng-recaptcha

Angular component for Google reCAPTCHA
https://dethariel.github.io/ng-recaptcha/
MIT License
475 stars 128 forks source link

upgrade to Angular v18 #325

Open LakhveerChahal opened 6 months ago

LakhveerChahal commented 6 months ago

@DethAriel Please have a look at the changes and let me know in case of any doubts/concerns.

ranbuch commented 5 months ago

@DethAriel Is there a timeline for this PR?

LakhveerChahal commented 5 months ago

For those who want it urgently: Published it as a new library under the name ng-recaptcha-2

ms-dosx86 commented 5 months ago

@LakhveerChahal If you need it so badly why don't you just run npm i --legacy-peer-deps? It's kinda ugly but fine as a temporary solution.

LakhveerChahal commented 5 months ago

As you said, it's ugly and I was kind of losing hope that this PR will get merged anytime soon.

KissBalazs commented 3 months ago

Hi! Is there any reason why this is still not merged? We would like to avoid using the old deps approach for stability reasons.

MarcosPaulo775 commented 2 months ago

Is there a scheduled date for the merge?

fast-facts commented 2 months ago

Hi! Is there any reason why this is still not merged? We would like to avoid using the old deps approach for stability reasons.

Because this is abandonware

carriquiry-g commented 2 months ago

For those who want it urgently: Published it as a new library under the name ng-recaptcha-2

In case any one missed it, this is the same library but with the merge completed. I don't know if @LakhveerChahal will maintain it in the future, but it solves the issue until the next version of Angular drops

LakhveerChahal commented 2 months ago

For those who want it urgently: Published it as a new library under the name ng-recaptcha-2

In case any one missed it, this is the same library but with the merge completed. I don't know if @LakhveerChahal will maintain it in the future, but it solves the issue until the next version of Angular drops

I'll try my best to keep it up to date with latest Angular.

carriquiry-g commented 2 months ago

I'll try my best to keep it up to date with latest Angular.

Happy to help keeping it up to date

avatier-leonardoc commented 2 months ago

Please, merge this.

jurvi commented 1 month ago

@DethAriel Any chance we could get this one rolling? Kinda want to upgrade my project to ng 18 but don't want to do silly workarounds with legacy peer deps.