Feedback on week 5 project progress for deunitato

nus-se-bot commented 4 years ago

Leftovers from the previous week

[x] A version tagged A-gradle is in the repo(:heavy_check_mark: well done!)( :warning: The tag is slightly different from the expected value (A-Gradle). Please follow the exact tag in future )
[x] A version tagged Level-10 is in the repo(:heavy_check_mark: well done!)
You are done with previous weeks work(:heavy_check_mark: well done!)

Progress of this week

[x] At least 2 PRs are in your fork (:exclamation: try to do by next milestone)
[x] A version tagged A-Assertions is in the repo(:exclamation: try to do by next milestone)
[x] A version tagged A-CodeQuality is in the repo(:heavy_check_mark: well done!)
[x] You have no tag from categories B/C/D(:exclamation: try to do by next milestone)

_{Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 2020-02-12 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.}

Deunitato commented 4 years ago

I did my categories

Deunitato commented 4 years ago

I tagged it as well....

okkhoy commented 4 years ago

@cs2103-feedback-bot please update the observation for C-Statistics as completed

@Deunitato you haven't created PRs on your fork:

nus-se-bot commented 4 years ago

done

Deunitato commented 4 years ago

I pr but not sure if this is correct

okkhoy commented 4 years ago

Oh no! you need to PR from a branch to your own fork. The idea is to get you used to manage and merge PRs on GitHub. You can do any other PR from a branch to your own fork master. Then merge it on GitHub and pull the changes to your master.

Deunitato commented 4 years ago

Oh no.. im quite confuse on that. What do you mean by PR from a branch to own fork master?

okkhoy commented 4 years ago

When you create a pull request you can select the "base" to be your own master branch. the "head" should be the other branch. (see image below)

Deunitato commented 4 years ago

I think i have created it

okkhoy commented 4 years ago

Nope! You haven't. Check the message: where do you want the 56 commits to be merged? Not to your fork but to the semester fork. The whole point of this exercise is to get you to practice merging PRs on your remote repository. So creating a PR to the semester fork (nus-cs2103-ay1920s2:master) doesn't count as you can't merge it there.

Deunitato commented 4 years ago

ahhh I feel dumb :(

Deunitato commented 4 years ago

I hope this is it or ill flip the table and bang my head :(

okkhoy commented 4 years ago

Naah! that is fine. We are all learning! 👍

Deunitato commented 4 years ago

thank you for your help >_<

Deunitato / duke

Feedback on week 5 project progress for deunitato #4

Leftovers from the previous week

Progress of this week