search

Deunitato / pe

0 stars 0 forks source link

Item considered as already in the recipe even if made minor changes #5

Open Deunitato opened 4 years ago

Deunitato commented 4 years ago

No details provided. image.png

Replicate:

  1. Have a recipe
  2. use the exact recipe but change the metric

This also affects amount:

image.png

And comments:

image.png

nus-pe-bot commented 4 years ago

Team's Response

Thank you for your feedback.

This bug report was rejected because what was treated as a bug is in fact the expected behavior. In AB3, the duplicate person checker counts the person-to-add as a duplicate if the person-to-add has 1) the same name as an existing person, and 2) the same phone number or same email as an existing person. See image for reference: AB3 duplicate checker.PNG

In HealthyBaby (HYBB), the duplicate recipe checker works in a similar way. It counts the recipe-to-add as a duplicate if the recipe-to-add has 1) the same name as an existing recipe, and 2) the same time or same steps as an existing recipe. See image for reference (screenshot was taken from github repo after code freeze): HYBB duplicate recipe checker.PNG

Therefore, with the examples given above, since the name and steps of the recipe that you wanted to add had the same name and steps of an existing recipe, the app considered it as a duplicate (even though the time changed, the steps were the same). In other words, what was treated as a bug is in fact the expected behavior.

The reason why we chose these criteria to check for duplicates is because we understand that some recipes might involve the same ingredients! For example, in baking, there are a lot of common ingredients like eggs, flour, milk etc. So the chances of having two recipes with exactly the same ingredients can be slightly higher as compared to the other parameters.

On the other hand, it is very unlikely that the name, and the amount of prep-time or steps taken in any two given recipes are exactly the same. Using the same example of baking, even though certain recipes might contain the same ingredients, the way those ingredients are treated (ie. the steps) are expected to be different, therefore resulting in a different product. Furthermore, the names of these two baked products are definitely expected to be different, even though their ingredients might be the same. Going by this way of thinking, we chose to implement the duplicate recipe checker in this way.

Finally, we lowered the severity to "low" because of the reproducibility of this bug. Only in very rare cases will someone try to add a recipe that has the exact same 1) name, and 2) time or steps, so it is really unlikely that it will affect the normal operations of this app.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Should not be rejected

"Finally, we lowered the severity to “low” because of the reproducibility of this bug. Only in very rare cases will someone try to add a recipe that has the exact same 1) name, and 2) time or steps, so it is really unlikely that it will affect the normal operations of this app."

So your team does admit that it is a case that this could happen, thus this bug is still valid.

What if I want to add a recipe but i want to add different comments? In this case, your application will detect it as a duplicate even thou I merly just want to add a different comment and perhaps change the amount of ingredient used for the same recipe?

Nevertheless, this could also be a documentation bug if you had not document it in your user guide to alert the user.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]