search

Deunitato / pe

0 stars 0 forks source link

Undo redo does not work for filter #8

Open Deunitato opened 4 years ago

Deunitato commented 4 years ago

How to replicate:

  1. Filter/sort the list
  2. Undo
  3. The Undo does not undo the filter command

Assume the same for redo

nus-pe-bot commented 4 years ago

Team's Response

Thank you for your feedback.

This bug report was rejected because what was treated as a bug is in fact the expected behavior. Commands like list, find, and filter are commands that do not modify the state of the recipe book. It only searches out the appropriate recipes to display and changes what is shown on the UI. The undo and redo feature is expected to undo and redo actions that modifies the state of the recipe book (for example, addingredient, delete, editstep etc). Therefore, it is not expected to work on ther filter command.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This should not be rejected because according to the reason you have given (modifies state only), this is a documentation bug because you did not document this and alert the user that undo/redo will also affect these "non-state changing" commands.