DeutscheModelUnitedNations / munify-chase

CHASE conference software, part of MUN-Product Suite MUNify
GNU Affero General Public License v3.0
4 stars 1 forks source link

FontAwesome Kit Integration / Self Hosting FontAwesome Icons #63

Closed TadeSF closed 4 months ago

TadeSF commented 1 year ago

FontAwesome Kits are currently not supported in React with the npm font awesome package. Either must find a workaround how to use locally embedded svgs by FontAwesome or must wait until feature is released.

FA Support stated that React Kit Support is on their feature timeline for the near future. We should keep an eye on that!

m1212e commented 1 year ago

Could you post a link to the relases page, changelog, etc. here so we have a reference?

TadeSF commented 1 year ago

Possible Workaround: https://jeroenpelgrims.com/custom-fontawesome-kit-icons-in-react/

TadeSF commented 1 year ago

The changelog can be found here: https://fontawesome.com/docs/changelog/

TadeSF commented 6 months ago

Selfhosting would give more flexibility, less dependencie issues with password protected npm packages, long-term-solution if FA-Subscription is not renewed.

Prerequisite: Gitcrypt or similar enables to store licenced FA Pro Icons in Repository without having licence issues in open repository (see https://github.com/DeutscheModelUnitedNations/munify/issues/79)

m1212e commented 6 months ago

I agree. Yesterday I tried to help Robin setting up the project since he had some spare time and wanted to work on some issues, the font awesome license key thing is quite an annoyance regarding contributions of people we don't know and cannot give keys to. Maybe there is a way to do some kind of "proxies" when using those icons?

m1212e commented 4 months ago

https://github.com/DeutscheModelUnitedNations/munify/pull/168 will at least reduce our api calls

TadeSF commented 4 months ago

Solved in #169