DeuxHuitHuit / entry_relationship_field

A new way to create master-details pattern with Symphony's sections
http://symphonyextensions.com/extensions/entry_relationship_field/
Other
11 stars 13 forks source link

Selecting more than one relationship before save bug #37

Closed andrewminton closed 9 years ago

andrewminton commented 9 years ago

I'm using the Dev branch with Symphony 2.6beta2 and experience a weird UI behaviour before saving the main section.

Main section is an article with an ERF linked to an images section.. I want to associate more than one image with the Article so choose 'link to entry' and associate one image as expected... then it returns to the main section no problem and the association is present in the UI. Now before saving, click 'link to entry' again and I attempt to associate another image.. this time it returns to the main section but the association does not appear in the UI... but if you save the main section, the association has actually saved.. it's just not appearing. there is an error in the JS of the extension from what I can see... in relation to https://github.com/DeuxHuitHuit/entry_relationship_field/blob/dev/assets/publish.entry_relationship_field.js#L293 ??

Could that be related maybe?

nitriques commented 9 years ago

Can you please give me the js error message please ? :)

andrewminton commented 9 years ago

Uncaught TypeError: undefined is not a function

nitriques commented 9 years ago

symphonyOrderable is from the core... and I am not aware of it disappearing.. I can't test right now but will have the time to do it this afternoon (it's 10:54 here right now)

andrewminton commented 9 years ago

Ok cool, hmmm I wonder if there were changes introduced in 2.6 which meant this changed.. will dig around. gnight :)

nitriques commented 9 years ago

I am currently developing it using the latest integration branch so I'll see :)

andrewminton commented 9 years ago

It could be updating extension related. Just removed and re-added the extension after an install/uninstall operation and it now seems to have resolved itself.. does the update script include the 'allow_new' sql table maybe?

nitriques commented 9 years ago

does the update script include the 'create_new' sql table maybe?

Yeah going from 1.0.1 to 1.0.2 needs a table adjustment.

andrewminton commented 9 years ago

Ye maybe that's it then.

nitriques commented 9 years ago

Great! So we can close this issue ?

Really cool new pic BTW

andrewminton commented 9 years ago

On my install it's fine, but my colleague still experiences this weirdness... got a feeling it could be browser cache related for the core JS somehow.

Pic, Inspired by yourself! I loves my Mountain Biking see :)

andrewminton commented 9 years ago

Let's close it and if it returns raise it again.

nitriques commented 9 years ago

Good!

andrewminton commented 9 years ago

Hi there,

Just so you know.. Redactor v1.1.1 was the culprit... conflicting JS effects the symphonyOrderable function somehow. will dig around and see if it can be fixed up.

nitriques commented 9 years ago

Ok thanks for the info! Is Redactor modifying jQuery somehow ?

andrewminton commented 9 years ago

Just looking at Remies repo and there is a version of jQuery included with the extension.. 1.7 which seems to error in quite a few places.. and when Parenthesis Tabs is in use for multilingual as well... booom! it all goes bang.

On 12 January 2015 at 16:06, Nicolas Brassard notifications@github.com wrote:

Ok thanks for the info! Is Redactor modifying jQuery somehow ?

— Reply to this email directly or view it on GitHub https://github.com/DeuxHuitHuit/entry_relationship_field/issues/37#issuecomment-69593336 .

nitriques commented 9 years ago

Hum for sure 1.7 is really old. Why would someone ship jQuery with their extension ? The backend depended so on it for a long time now... And we currently use 2.1.3 (which is the latest)

andrewminton commented 9 years ago

I know right. I'm sure it was floating around before jquery was shipped as a core library though.. so maybe it's just legacy code that hasn't been touched in a while. Still it's broken so looking to fix where I can.. unfortunately we'd need a licence to get the latest build code which would work with jQuery 2.1.3 I'd imagine.

nitriques commented 9 years ago

:(