search

DeuxHuitHuit / framework.js-modules

Collections of modules we frequently use with our framework, https://github.com/DeuxHuitHuit/framework.js
https://deuxhuithuit.github.io/
Other
3 stars 8 forks source link

Changed commas for spaces #350

Closed fhamon closed 4 years ago

fhamon commented 4 years ago

A bit weird. I personally prefer the commas, but this change is better for readbility in our XSLT stack.

Right now, if we notify multiple things with one state, we need to separate everything by a comma and our "" logic only add spaces.

so instead of this: <add data-visible-state-notify-off="site.addScroll,autoOembed.pauseAll" />

we can do this:

<add data-visible-state-notify-off="site.addScroll" />
 <add data-visible-state-notify-off="autoOembed.pauseAll" />
nitriques commented 4 years ago

Why not keep both ?

fhamon commented 4 years ago

Why not keep both ?

we could

nitriques commented 4 years ago

This would make it a non-breaking change ;)

nitriques commented 4 years ago

@fhamon ping

fhamon commented 4 years ago

@nitriques done