search

DeuxHuitHuit / framework.js-modules

Collections of modules we frequently use with our framework, https://github.com/DeuxHuitHuit/framework.js
https://deuxhuithuit.github.io/
Other
3 stars 8 forks source link

Use the whole fragment changed for the article handle #387

Closed fhamon closed 3 years ago

fhamon commented 4 years ago

I added the label bug cause our XSLT that generates the articles handles are already ready for this change.

So the default detail page would take the whole handle (exept the hash in the URL of course) to display it's content. That includes query-strings.

What motivated this change was for support of pages with multiple parameters in the URL /en/{handle1}/{handle2}/. This change works well for the framwork and the page treat is as another article which is fine in that context.

And yeah, query-string support for quick an easy filter page with this model.

nitriques commented 4 years ago

How could we make it so that the old code, which is still useful, won't be lost ?

How can we make the old style still the default, but make it super easy to opt-in ?

fhamon commented 4 years ago

It's only a default template. So I don't think we should support legacy versions.

It's not a breaking change on any components for anything. It's someting that I use since 2018