search

DeuxHuitHuit / quicksearch

A jQuery plugin for searching through DOM Elements quickly
https://www.npmjs.org/package/jquery.quicksearch
Other
135 stars 35 forks source link

New callback: onNoResultFound #20

Closed micaelomota closed 8 years ago

micaelomota commented 8 years ago

resubmit #19

micaelomota commented 8 years ago

I got it :D and did as you suggested \o/

nitriques commented 8 years ago

It is! Thanks!

nitriques commented 8 years ago

Oh Last thing: There a typo in the function's name.

onNoResultsFound -> onNoResultFound (drop the plural)

Thanks!

micaelomota commented 8 years ago

haha, sorry, i am learning english yet

nitriques commented 8 years ago

sorry, i am learning english yet

No worries :) The critic is not on you, it's purely on the code and we are all here to learn ;)

micaelomota commented 8 years ago

Hey man, the PR will be accepted ?

nitriques commented 8 years ago

Hey man, the PR will be accepted ?

Yup 2.1.0 has been released with it!

micaelomota commented 8 years ago

:D thanks!!!

nitriques commented 8 years ago

It's also available on npm :)

nitriques commented 8 years ago

And thanks to you !

micaelomota commented 8 years ago

Hey man, I'm not on the contributors list...

nitriques commented 8 years ago

Which contributor list ?

micaelomota commented 8 years ago

This... https://github.com/DeuxHuitHuit/quicksearch/graphs/contributors

nitriques commented 8 years ago

Looks like you github profile email and the one you used in the commits does not match.

I can't click on your name

image

micaelomota commented 8 years ago

Oh.... :/.. My email was private, i changed it now. Maybe was it that?

nitriques commented 8 years ago

Sadly, no since your email is included in each commit.

image