search

Dev-AliGhasemi / SE-HW1-ACM

SE-HW1-ACM
0 stars 0 forks source link

feedback #1

Open JKarimi12 opened 2 months ago

JKarimi12 commented 2 months ago

https://github.com/Dev-AliGhasemi/SE-HW1-ACM/blob/42b058f11090c457eeb64aa478e8e5db065d2e8c/queries.py#L5

bad pattern

JKarimi12 commented 2 months ago

BankingSystem -> banking_system

JKarimi12 commented 2 months ago

where is .gitignore?

JKarimi12 commented 2 months ago

add requirements.txt

JKarimi12 commented 2 months ago

https://github.com/Dev-AliGhasemi/SE-HW1-ACM/blob/42b058f11090c457eeb64aa478e8e5db065d2e8c/account/models.py#L7 چه نیازی به این فیلد بود؟

JKarimi12 commented 2 months ago

https://github.com/Dev-AliGhasemi/SE-HW1-ACM/blob/42b058f11090c457eeb64aa478e8e5db065d2e8c/queries.py#L56 این فیل می‌شه. باید ترنزکشن داشته باشه.

JKarimi12 commented 2 months ago

https://github.com/Dev-AliGhasemi/SE-HW1-ACM/blob/42b058f11090c457eeb64aa478e8e5db065d2e8c/queries.py#L43C34-L43C43 order_by?

Dev-AliGhasemi commented 2 months ago

https://github.com/Dev-AliGhasemi/SE-HW1-ACM/blob/42b058f11090c457eeb64aa478e8e5db065d2e8c/queries.py#L5

bad pattern

Im have long experience in Java and i new in Python. Thanks for your quote. star is a bad pattern ? (for performance reason?)