search

Dev-Sambhav / background_remover

[Open Source] Background remover site built in React JS
https://master--background-remover.netlify.app/
MIT License
1 stars 1 forks source link

[feat]: UI could be better designed #1

Closed Dev-Sambhav closed 9 months ago

Dev-Sambhav commented 10 months ago

Enhanced the user interface to improve overall design look. The changes include updated color schemes, refined layout, and improved visual elements to provide a more polished and user-friendly experience. If you want, you can also use Tailwind CSS.

inyCation commented 10 months ago

#1 can we use typescript??

Dev-Sambhav commented 10 months ago

#1 can we use typescript??

yes, you can 👍

inyCation commented 10 months ago

#1 can we use typescript??

yes, you can 👍

Will convert the whole app with ts, after that will start on UI !! One more thing, can we use scss too??

Dev-Sambhav commented 10 months ago

#1 can we use typescript??

yes, you can 👍

Will convert the whole app with ts, after that will start on UI !! One more thing, can we use scss too??

You can convert the whole app with TS but use Tailwind CSS for the styling part

inyCation commented 10 months ago

hey sambhav,
i have implemented TS, and have opened a pull request. you can review the code and let me know if we need other changes,

live link - https://iridescent-banoffee-148d16.netlify.app/

Dev-Sambhav commented 10 months ago

Great job @inyCation but in future, whenever you work on any issue, create a separate branch. never change in main branch

img
Dev-Sambhav commented 10 months ago

@inyCation This issue is still open as the UI is still not changed so you can start if you want to change.

inyCation commented 10 months ago

@Dev-Sambhav I'm on it , Will create a pull request as soon as I get it done.

inyCation commented 10 months ago

1

hey, @Dev-Sambhav can you review the UI and let me know if we need any changes.

link - https://relaxed-cupcake-eaeb68.netlify.app/

Dev-Sambhav commented 10 months ago

@inyCation, I think it will look better if we keep things in one column, also remove the navbar as currently it is a one page site or if you want to add about section then do it in the same page means create a about section and place it at the bottom of the homepage.

image
inyCation commented 10 months ago

1

hey @Dev-Sambhav , i have removed the navbar, and have aligned home section in column, let me know if we need other changes.

live - https://relaxed-cupcake-eaeb68.netlify.app/

Dev-Sambhav commented 9 months ago

@inyCation Great, now open a PR so I can merge your commit. Hope you have committed all the changes in a separate branch.

Note:- Fixes: #1 must be written in the PR description so that this issue gets added to the PR.