search

Dev10000 / dasmotos-arts-crafts

1 stars 0 forks source link

Summary #6

Open ghost opened 7 years ago

ghost commented 7 years ago

Satisfactory 👍

Great job reproducing the web page according to the design mock. You've written some very clear and efficient HTML & CSS as well, good job!

Try going back and using the same class names on equivalent sections so that your CSS selectors are more descriptive. If the div tags had the same class, you could write some much more self-documenting CSS like .product h2 instead of just h2.

Dev10000 commented 7 years ago

Fixed the CSS selectors more descriptive.

Thanks for the feedback and the great pointers, I have been keeping these in mind when done the other projects, especially more descriptive CSS was an eye-opener. But I hope there comes something about the SEO in the course, like I said before, every developer should know how to develop SEO friendly websites. There is no point to having a website if no one can find it :)

https://github.com/TimRNR/dasmotos-arts-crafts/commit/faa10c4144e7422e0961f5be26d8512fc4f31bb0