Dev1an / Swift-Atem

Blackmagic Design Atem network protocol implementation in swift 5.1 using NIO 2
MIT License
58 stars 27 forks source link

`ConnectionInitiationEnd` message should be public #23

Closed martinprot closed 11 months ago

martinprot commented 1 year ago

When I initialize the controller, I would like to know once the init status is OK. The documentation says :

When this connection initiation process is finished the ConnectionInitiationEnd message will be sent. From that moment on you know that a connection is succesfully established.

But ConnectionInitiationEnd is not declared public, so the following code does not compile.

self.controller = try Controller(ipAddress: "192.168.0.48") { connection in
      connection.when{ (message: ConnectionInitiationEnd) in
          print(message)
      }
}

Solution: add the public visibility to ConnectionInitiationEnd struct.

maxbaeumle commented 1 year ago

The same message (InCm) is available as public struct Message.Config.InitiationComplete here.