search

Dev4X / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #850

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name: item-selection-widget

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=8ba94dff705cc0a48813767310d5798f
59a022b9&name=item-selection-widget
https://code.google.com/p/oppia/source/detail?r=e336b8a0dfbabcd4b83374e9d3648da7
3de3db19&name=item-selection-widget
https://code.google.com/p/oppia/source/detail?r=f935539e3c41a8621d00f9b96f913af9
be93818c&name=item-selection-widget

Purpose of code changes on this branch: Progress check on item-selection-widget

When reviewing my code changes, please focus on: Compatibility with the updated 
Oppia base and that changes are as expected. 

After the review, I'll continue development of this widget.

Original issue reported on code.google.com by kevinlee...@gmail.com on 9 Jul 2015 at 6:41

GoogleCodeExporter commented 9 years ago 
Ben, if time permits, would you like to take a pass at this? If time doesn't 
permit, don't worry.

(For background, look at the doc in the folder "Design" > "Specifications" > 
"Multiple Choice vs Item Selection".)

Original comment by s...@seanlip.org on 9 Jul 2015 at 7:19

GoogleCodeExporter commented 9 years ago 
Yeah, I'll take a pass.

Original comment by bhenn...@google.com on 9 Jul 2015 at 5:38

GoogleCodeExporter commented 9 years ago 
One concern that I have: If multiple items may be selected, how do we provide 
feedback for the selection based on the rules? We just removed the ability to 
connect rules together using AND connectors. Do we need to add special rules 
that check multiple inputs at once?

Original comment by bhenn...@google.com on 9 Jul 2015 at 6:36

GoogleCodeExporter commented 9 years ago 
Yes. The "answer" in this case consists of a list of possibilities, not just 
one choice. So it's not really a question of AND connectors -- it's a different 
rule type altogether.

Original comment by s...@google.com on 9 Jul 2015 at 6:39

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Ah, so the equals check should behave similarly to SetInput, then? Where equals 
is responsible for taking in a set input and comparing it to the answer set the 
user submits.

Original comment by bhenn...@google.com on 9 Jul 2015 at 6:54

GoogleCodeExporter commented 9 years ago 
Yes, that's right.

Original comment by s...@seanlip.org on 10 Jul 2015 at 1:19