Open GoogleCodeExporter opened 9 years ago
This looks very good overall! With regards to your questions:
(1) I think this is fine for now.
(2) Up to you.
(3) Test coverage seems reasonable; I commented in cases where I thought some
could be added.
(4) It would be nice to do this, but it's also OK to leave it for later if you
don't have bandwidth.
(5, 6) Please ask Amit (cc'd).
(7) I picked up on that in the review too, and I don't like it. Can we perhaps
disambiguate by destination in that case?
(8) Yes, or somewhere sensible.
Original comment by s...@google.com
on 24 Jul 2015 at 7:50
Original issue reported on code.google.com by
bhenn...@google.com
on 23 Jul 2015 at 4:48