search

DevAhamed / MultiViewAdapter

Easily create complex recyclerview adapters in android
https://devahamed.github.io/MultiViewAdapter
Apache License 2.0
818 stars 149 forks source link

Show/hide child sections when NestedSection's show/hide api is called #93

Closed DevAhamed closed 5 years ago

DevAhamed commented 5 years ago

Previously when the NestedSection is being shown or hidden, its child section's visibilities are untouched. But this might create issues when selection or expansion is toggled ie., incorrect selection / expansion flags are set to the child section even though the parent's is not visible in the adapter. So we set visibility to all child section which will produce the correct behavior.

codecov-io commented 5 years ago

Codecov Report

Merging #93 into 2.x will increase coverage by 0.11%. The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x      #93      +/-   ##
==========================================
+ Coverage   76.04%   76.15%   +0.11%     
==========================================
  Files          20       20              
  Lines        1152     1170      +18     
  Branches      168      172       +4     
==========================================
+ Hits          876      891      +15     
  Misses        176      176              
- Partials      100      103       +3
Impacted Files Coverage Δ
...pter/src/main/java/mva2/adapter/NestedSection.java 81.03% <83.33%> (+0.12%) :arrow_up:
...ew-adapter/src/main/java/mva2/adapter/Section.java 71.42% <85.71%> (+0.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c940ec...d91a484. Read the comment docs.