search

DevAhamed / MultiViewAdapter

Easily create complex recyclerview adapters in android
https://devahamed.github.io/MultiViewAdapter
Apache License 2.0
818 stars 148 forks source link

Show/hide child sections when NestedSection's show/hide api is called #94

Closed DevAhamed closed 5 years ago

DevAhamed commented 5 years ago

Previously when the NestedSection is being shown or hidden, its child section's visibilities are untouched. But this might create issues when selection or expansion is toggled ie., incorrect selection / expansion flags are set to the child section even though the parent's is not visible in the adapter. So we set visibility to all child section which will produce the correct behavior.

Note : This change was cloned from 2.x branch

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (3.x@c87784e). Click here to learn what that means. The diff coverage is 84.61%.

Impacted file tree graph

@@          Coverage Diff           @@
##             3.x      #94   +/-   ##
======================================
  Coverage       ?   77.48%           
======================================
  Files          ?       20           
  Lines          ?     1177           
  Branches       ?      174           
======================================
  Hits           ?      912           
  Misses         ?      160           
  Partials       ?      105
Impacted Files Coverage Δ
...pter/src/main/java/mva3/adapter/NestedSection.java 81.03% <83.33%> (ø)
...ew-adapter/src/main/java/mva3/adapter/Section.java 71.42% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c87784e...5a2bfa4. Read the comment docs.