search

DevAlien / workspaces

Workspaces app for linux elementaryos gtk
GNU General Public License v3.0
79 stars 13 forks source link

Make it easier to close the Overlay window #14

Closed matfantinel closed 4 years ago

matfantinel commented 4 years ago

Currently, when I use the shortcut to bring up the Overlay and select a workspace to open, the overlay window stays there. To close it, I have to focus on the search bar and then press Esc:

Current Behavior

This makes it hard to close the window, and, in my example (which just opens the Calculator app), it hides the opened app, which makes me think the action didn't work.

Planner on AppCenter also has a shortcut + overlay flow, and it's easier to close it. It has both a "Cancel" button, and also gets closed when you click outside of the window:

Desired Behavior

I think this is a much more intuitive flow, specially if the overlay also closes if a Workspace is selected too. I understand this might be an issue if the user wants to open multiple Workspaces though.

matfantinel commented 4 years ago

Planner seems to handle the "click-outside" event on line 272 here: https://github.com/alainm23/planner/blob/master/src/QuickAdd/MainWindow.vala

DevAlien commented 4 years ago

Thanks for the report, the click-outside is interesting, I can probably integrate that. but in the case of the calculator is still a stange behaviour. What do you think of having the click-outside and then when you click or press enter on an item, it automatically closes it.

But if you do CTRL + click or CTRL + Enter it will stay open, so that you can launch more stuff.

Would be cool if it could keep the focus as well.

matfantinel commented 4 years ago

I really like the idea! Could be also made more discoverable through a tooltip.

Also, about the Calculator opening up behind the overlay, that might be a Gala bug. I had that happen before, specially with the Mail app (when opened from a notification, it doesn't show up immediatelly, and has a red dot on the dock)

DevAlien commented 4 years ago

Yes, I will probably go the way with the control. It stays behind because I made the app to stay in front of everything else (like a message dialog)