search

DevBobcorn / AcryliCraft

Apply Fluent Design materials to Minecraft window.
https://modrinth.com/mod/acrylicraft
MIT License
27 stars 3 forks source link

1.5.0 Fabric version number is written as `0.0.0` #3

Closed 3gf8jv4dv closed 5 months ago

3gf8jv4dv commented 5 months ago

First of all, kudos to you for the new features you implemented in 1.5.0! When I recently noticed that the relevant version of Minecraft 1.20.5 applied panoramas to multiple interfaces, I was thinking about whether to make relevant suggestions, but I didn't expect that you implemented it first. It feels very good!

I noticed that the version field in the fabric.mod.json file was written as 0.0.0; in contrast, the previous version was correctly written as 1.4.0.

This is noticed because some launchers are able to read fabric.mod.json and display its version number. Plus after installing the Mod Menu it prompted me that there was an update for the mod (but I did install 1.5.0). Not sure if it was intentional or not, I thought about it and mentioned it anyway.

DevBobcorn commented 5 months ago

Well, actually it was a bug with the build script, the version number was not being properly written into fabric.mod.json so i hard coded it as a temporary fix. I'll look into the build script again and see if I can get it working.