search

DevBobcorn / AcryliCraft

Apply Fluent Design materials to Minecraft window.
https://modrinth.com/mod/acrylicraft
MIT License
27 stars 3 forks source link

1.5.0 Fabric and Sodium Extra will cause crashes #4

Closed 3gf8jv4dv closed 5 months ago

3gf8jv4dv commented 5 months ago

Everything works fine when installing only AcryliCraft and its dependencies, and then Sodium or Embeddium. On this basis, launching the game after installing Sodium Extra crashes without the game window even appearing.

Crash log: (Deleted)

DevBobcorn commented 5 months ago

Looks like it is that AcryliCraft and Sodium Extra both injected some code around the GLFW default window hints invocation, which confuses the mod loader and eventually leads to a crash. This can be a bit tricky, but I'll do some research and see if I can make them work together.

DevBobcorn commented 5 months ago

Guess I've found it: https://github.com/FlashyReese/sodium-extra-fabric/blob/cdb15d75cdca99813b17b4e64c47000940009f8b/src/main/java/me/flashyreese/mods/sodiumextra/mixin/reduce_resolution_on_mac/MixinWindow.java#L31-L38

DevBobcorn commented 5 months ago

So, I replaced my Redirect with Inject and... It just worked! I thought Inject operations are not allowed in constructors. Anyway, the problem's solved: MAGIC

3gf8jv4dv commented 5 months ago

So glad to know this good news!

An off topic question by the way. Is NeoForge not fully implemented because of some obstacles? Just curious, I am not in a hurry, after all NeoForge is still in beta stage.

DevBobcorn commented 5 months ago

Yep. YACL is not yet available for NeoForge 1.20.5, and NeoForge 1.20.5 seems to have introduced some breaking changes. So it will probably still be a while before everything gets updated.