DevChatter / ChatterBot

Highly modular Twitch chat bot.
MIT License
10 stars 5 forks source link

#31 Assembly Restructure #38

Closed SimonGeering closed 4 years ago

SimonGeering commented 4 years ago

Resolves #31 Assembly restructure to clean architecture

SimonGeering commented 4 years ago

@benrick this is ready for review. I have deliberately left in the Core folders and the namespaces are un-changed to ensure non-breaking compatibility.

That having been said I would argue that the Core namespace can be removed, with classes migrated into the Domain, UI, and Infra namespaces or sub-namespaces thereof.

This could be done as one or two subsequent PRs, depending on if you want to do the namespace change and file system change in one go, or do the namespace change as a preliminary PR to chat it all works and move the files after that.

benrick commented 4 years ago

Same PR or separate PR doesn't matter to me, as long as it's at least 2 separate commits when doing it. Helps to avoid small files getting mistaken for an add/delete instead of a move.