DevCom-IITB / instiapp-api

Django quasi-RESTful API for InstiApp!
https://insti.app
GNU Affero General Public License v3.0
22 stars 75 forks source link

chore: update django to 3.0 #430

Closed e-aakash closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #430 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #430   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          113       113           
  Lines         4302      4302           
=========================================
  Hits          4302      4302           
Impacted Files Coverage Δ
other/tests.py 100.00% <ø> (ø)
venter/admin.py 100.00% <ø> (ø)
bodies/models.py 100.00% <100.00%> (ø)
bodies/serializers.py 100.00% <100.00%> (ø)
bodies/serializers_followers.py 100.00% <100.00%> (ø)
events/models.py 100.00% <100.00%> (ø)
events/serializers.py 100.00% <100.00%> (ø)
locations/models.py 100.00% <100.00%> (ø)
upload/models.py 100.00% <100.00%> (ø)
users/serializer_full.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04dfca3...51e1eae. Read the comment docs.

pulsejet commented 4 years ago

@e-aakash I think the problematic line in question here this one https://github.com/wncc/instiapp-api/blob/04dfca352d390638d88bb1860a40a25d99a9f3ff/other/management/commands/reconstruct-search.py#L24

Enumerating the queryset is a synchronous only operation, which we are doing from an async call (on the main thread, sure), so django disallows this. A fix would probably be to first fetch the queryset and then pass it to the async function (querysets in django are lazy loaded, so this isn't happening right now)

pulsejet commented 4 years ago

LGTM 💯

Just suppress off all lint errors; none are relevant