e-aakash commented 3 years ago

User is logged in if profile already exists, making SSO login required first step for this to work

TODO: Add tests. Do we have to add dummy server like that for SSO?

codecov[bot] commented 3 years ago

Codecov Report

Merging #452 (ca52712) into master (c86b74b) will decrease coverage by 0.51%. The diff coverage is 23.33%.

:exclamation: Current head ca52712 differs from pull request most recent head 932afec. Consider uploading reports for the commit 932afec to get more accurate results

@@             Coverage Diff             @@
##            master     #452      +/-   ##
===========================================
- Coverage   100.00%   99.48%   -0.52%     
===========================================
  Files          113      113              
  Lines         4457     4471      +14     
===========================================
- Hits          4457     4448       -9     
- Misses           0       23      +23

Impacted Files	Coverage Δ
login/urls.py	`100.00% <ø> (ø)`
login/helpers.py	`90.51% <8.33%> (-9.49%)`	:arrow_down:
login/views.py	`84.61% <33.33%> (-15.39%)`	:arrow_down:
placements/tests.py	`100.00% <0.00%> (ø)`
placements/views.py	`100.00% <0.00%> (ø)`
placements/models.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c86b74b...932afec. Read the comment docs.

e-aakash commented 3 years ago

@pulsejet any ideas on why this migration is failing. I haven't seen these fail before.

e-aakash commented 3 years ago

Gymkhana SSO is public again, google login is no longer required

DevCom-IITB / instiapp-api

Add Google login support #452

Codecov Report