Krishna-Baldwa
commented
1 year ago Cool..Will make the respective changes
On Fri, May 5, 2023 at 4:52 PM Palash Mittal @.***> wrote:
@.**** requested changes on this pull request.
- Make sure its passing linting checks.
- Resolve all changes I have mentioned.
On assets/buy&sell/No-image-found.jpg https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185960136 :
In place of this use the blank image that is being used in add event
In assets/login/login.html https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185960631 :
@@ -107,10 +107,10 @@
- - - + href="https://gymkhana.iitb.ac.in/profiles/oauth/authorize/?client_id=5jyMJufq0Vk0aDlj9Hnudsj84UfbFZlYRUnn02Xd&response_type=code&scope=basic%20profile%20picture%20sex%20ldap%20phone%20insti_address%20program%20secondary_emails&redirect_uri=https://www.insti.app/login-android.html">Change this back to the correct one
In lib/main.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185961523 :
@@ -304,10 +314,21 @@ class MyAppState extends State
with WidgetsBindingObserver { return _buildRoute(settings, ChatPage()); case "/groups": return _buildRoute(settings, CommunityPage());
- case "/buyNsell":
Don't keep capitals in route name
In lib/src/api/apiclient.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185961784 :
@@ -42,9 +44,9 @@ import 'package:dio/dio.dart'; import 'model/offersecret.dart'; part 'apiclient.g.dart';
-// @rt.RestApi(baseUrl: "http://192.168.230.89:8000/api") -// @rt.RestApi(baseUrl: "http://10.105.177.150/api") @.(baseUrl: "https://gymkhana.iitb.ac.in/instiapp/api") @.(baseUrl: "https://9a1d-103-21-125-85.ngrok-free.app/api")
Change this to gymkhana
In lib/src/api/apiclient.g.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185962192 :
@@ -8,8 +8,7 @@ part of 'apiclient.dart';
class _InstiAppApi implements InstiAppApi { _InstiAppApi(this._dio, {this.baseUrl}) {
- // baseUrl ??= 'http://192.168.230.89:8000/api';
- baseUrl ??= 'https://gymkhana.iitb.ac.in/instiapp/api';
- baseUrl ??= 'https://9a1d-103-21-125-85.ngrok-free.app/api';
Change this back to gymkhana
On lib/src/api/response/buynsell_post_list_response.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185964041 :
Is this still being used?
On lib/src/blocs/buynsell_post_block.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185964641 :
fix spelling of filename
In lib/src/blocs/buynsell_post_block.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185965205 :
+ +class BuynSellPostBloc {
- final String storageID = "BuynSellPost";
- InstiAppBloc bloc;
- List
_buynsellPosts = []; - ValueStream<List
> get buynsellposts => _buynsellSubject.stream; - final _buynsellSubject = BehaviorSubject<List
>(); - String query = "";
- BuynSellPostBloc(this.bloc);
- get buynsellpost => null;
Remove unused variable
In lib/src/drawer.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185969114 :
@@ -667,7 +680,8 @@ class MNavigatorObserver extends NavigatorObserver { "/messcalendar": 14, "/messcalendar/qr": 14, "/groups": 15,
- "/InSeek": 16,
- // "/InSeek": 16,
If inseek was 16 why is buynsell also 16? It might be possible that inseek is restored in the future. So change the number to 17
In lib/src/routes/buynsell_categories.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185970783 :
- ),
- Padding(
- padding: const EdgeInsets.all(14.0),
- child: Row(
- mainAxisAlignment: MainAxisAlignment.spaceAround,
- crossAxisAlignment: CrossAxisAlignment.start,
- children:
[ - CategoryButton("Sports"),
- CategoryButton("Miscellaneous"),
- Expanded(child: Container()),
- ],
- ),
- ),
- ]),
- ), +//
Unnecessary comment ⬇️ Suggested change
-//
In lib/src/routes/buynsell_info.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185971217 :
- //Map data = ModalRoute.of(context).settings.arguments;
- //str_id = data?['str_id'];
- // ignore: avoid_print
⬇️ Suggested change
- //Map data = ModalRoute.of(context).settings.arguments;
- //str_id = data?['str_id'];
- // ignore: avoid_print
In lib/src/routes/buynsell_info.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185971539 :
- )),
- Row(
- crossAxisAlignment: CrossAxisAlignment.start,
- mainAxisAlignment: MainAxisAlignment.start,
- children:
[ - Padding(
- padding: EdgeInsets.fromLTRB(25, 10, 25, 0),
- child: Text(
- 'Contact Details - ' +
- (bnsPost?.contactDetails ?? ""),
- style:
- TextStyle(fontWeight: FontWeight.bold)))
- ]),
- ]),
- ),
- ) //Column
⬇️ Suggested change
- ) //Column
- )
In lib/src/routes/buynsell_page.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185971692 :
+import 'package:InstiApp/src/drawer.dart'; +import 'package:InstiApp/src/utils/common_widgets.dart'; + +import '../api/model/user.dart'; +import '../utils/title_with_backbutton.dart'; + +class BuySellPage extends StatefulWidget {
- BuySellPage({Key? key}) : super(key: key);
- final GlobalKey
_scaffoldKey = GlobalKey(); - @override
- State
createState() => _BuySellPageState(); +} +class _BuySellPageState extends State
{ - // This widget is the root of your application.
⬇️ Suggested change
- // This widget is the root of your application.
In lib/src/routes/buynsell_page.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185971863 :
+
- @override
- State
createState() => _SellpageState(); +} +class _SellpageState extends State
{ - final GlobalKey
_scaffoldKey = GlobalKey(); - BnSType bnstype = BnSType.All;
- bool firstBuild = true;
- bool MyPosts = false;
- @override
- void initState() {
- super.initState();
- // _firstLoad();
⬇️ Suggested change
- // _firstLoad();
In lib/src/routes/buynsell_page.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185972201 :
- // TextSpan(
- // text: "\"${communityBloc.query}\"",
- // style: TextStyle(fontWeight: FontWeight.bold)),
- // TextSpan(text: "."),
⬇️ Suggested change
- // TextSpan(
- // text: "\"${communityBloc.query}\"",
- // style: TextStyle(fontWeight: FontWeight.bold)),
- // TextSpan(text: "."),
In lib/src/routes/buynsell_page.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185972510 :
- // Container(co
- // child: SizedBox(
- // child: Container(
- // child: LikeButton(
- // bubblesSize: 0,
- // ),
- // ),
- // height: 40,
- // width: 40,
- // ))
⬇️ Suggested change
- // Container(co
- // child: SizedBox(
- // child: Container(
- // child: LikeButton(
- // bubblesSize: 0,
- // ),
- // ),
- // height: 40,
- // width: 40,
- // ))
In pubspec.yaml https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185973515 :
@@ -88,6 +88,7 @@ flutter:
- assets/communities/emojis/
- assets/map/assets/
- assets/map/assets/map/
- assets/buy&sell/
No & in folder names!!!!
On assets/buy&sell/blank.png https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185974948 :
Is this blank required?
In lib/src/blocs/buynsell_post_block.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185976146 :
- }
- Future<BuynSellPost?> deleteBuynSellPost(String id) async {
- return await bloc.client.deleteBuynSellPost(bloc.getSessionIdHeader(), id);
- }
- Future
updateBuynSellPost(BuynSellPost post) async { - await bloc.client
- .updateBuynSellPost(bloc.getSessionIdHeader(), post.id!, post);
- }
- Future
refresh({BnSType type = BnSType.All}) async { - _buynsellPosts =
- (await bloc.client.getBuynSellPosts(bloc.getSessionIdHeader()));
- // print("community" + _communityPosts.toString());
⬇️ Suggested change
- // print("community" + _communityPosts.toString());
In lib/src/blocs/buynsell_post_block.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185976449 :
- //Future
deleteBuynSellPost(String id) async { - //}
⬇️ Suggested change
- //Future
deleteBuynSellPost(String id) async { - //}
On lib/src/api/response/buynsell_post_list_response.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185964353 :
Remove this as it is not being used
In lib/src/drawer.dart https://github.com/DevCom-IITB/instiapp-flutter/pull/34#discussion_r1185977193 :
@@ -667,7 +680,8 @@ class MNavigatorObserver extends NavigatorObserver { "/messcalendar": 14, "/messcalendar/qr": 14, "/groups": 15,
- "/InSeek": 16,
- // "/InSeek": 16,
⬇️ Suggested change
- // "/InSeek": 16,
- "/InSeek": 16,
— Reply to this email directly, view it on GitHub https://github.com/DevCom-IITB/instiapp-flutter/pull/34#pullrequestreview-1414577589, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW3KQYLE4YQ4VKKWLAN6MX3XETPIHANCNFSM6AAAAAAXUV5KGU . You are receiving this because you authored the thread.Message ID: @.***>
A new page added to the navigation bar of InstiApp. People can post the products they want to sell and the page helps them connect with a good number of potential buyers within the institute. Key features include post, delete, view all and view details of product.