DevDavido / performance-audit-plugin

Daily performance audits of all your sites in Matomo.
GNU General Public License v3.0
12 stars 4 forks source link

Remove anchor in url #33

Closed ghost closed 3 years ago

ghost commented 3 years ago

Hi,

First, thank you for your excellent work.

What do you think of removing anchors ( Fragment ) from urls ?

Before push a PR i ask you ?

Sorry for my english.

DevDavido commented 3 years ago

Hi, thank you for your kind words :) A PR for removing anchors is fine as long as it's performant (as some users have millions of URLs) and is controllable on a per-site setting (as certain sites have frontends which depend on the anchor). Here's the part for collecting URLs and mainly here for site settings.

ghost commented 3 years ago

I can use a similar method of groupUrlsByPath

And i add a config site value similar to $hasGroupedUrls

Peoples can choose :

Say me if the way is ok for you.

DevDavido commented 3 years ago

Ok good, maybe you can incorporate the group by URL path setting into a selection of yours like:

Group by...

Basically a combination of all possibilities đź‘Ť This would be great!

ghost commented 3 years ago

I don't understand Group by URL path

It's only if we want test one url of the path ?

www.mysite.com/boots/my-boots-1.php www.mysite.com/boots/my-boots-2.php www.mysite.com/boots/my-boots-3.php

We only test www.mysite.com/boots/my-boots-1.php or www.mysite.com/boots/my-boots-2.php and on the repport we put www.mysite.com/boots/

For anchor it's ok i need to add translations .

Capture d’écran de 2021-02-09 13-22-57

DevDavido commented 3 years ago

The group by URL path is cutting off everything from the query string on, so only the scheme, host and path remains and removes possible resulting duplicates. The path includes possible file names. Is it that what you asked?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Thank you for your contributions.