DevDegree / eng-intern-challenge

10 stars 2.98k forks source link

Invalid String Input #560

Closed Aviral-03 closed 1 month ago

Aviral-03 commented 1 month ago

Corner Case Issue:

When converting the string '12ab' from English to Braille, the output is '1212' in Braille. This occurs because the Braille patterns for the numbers '1' and '2' are the same as the patterns for the letters 'a' and 'b', respectively. Without any space between the numbers and letters, so number is continued until the space or end of string is seen: the Braille output could be interpreted as either '12ab' or '1212'.

Question:

Should this be considered a valid translation, or should the translator raise an error due to the potential for misinterpretation?

doublederek commented 1 month ago

According to the instructions in the Readme: "When a Braille number follows symbol is read, assume all following symbols are numbers until the next space symbol."