search

DevExpress / devextreme-reactive

Business React components for Bootstrap and Material-UI
https://devexpress.github.io/devextreme-reactive/
Other
2.07k stars 376 forks source link

Custom column sort icon in Bootstrap4 template #2541

Open iegik opened 4 years ago

iegik commented 4 years ago

I'm using ...

React Grid

Description

Installation of the OpenIconic icons for Bootstrap4 version

Is not necessary, if you don't want to use these icons. But there is only one solution to replace sorting icons - replace TableHeaderRow's sortLabelComponent

So, I propose to add sortIconComponent for SortLabel

iegik commented 4 years ago

https://github.com/DevExpress/devextreme-reactive/pull/2540

LazyLahtak commented 4 years ago

Hi @iegik,

Thank you for your interest in our Grid. We'll help you implement this feature.

First of all, we implement all features for all themes (Material-UI, Bootstrap 3, Bootstrap 4). It would be great to add implementations for Material-UI and Bootstrap 3 in your pull request.

Also, we provide components via a plugin's properties. For example, the TableHeaderRow plugin has the sortLabelComponent property. You need to add sortIconComponent in the TableHeaderRow plugin and pass it to the SortLabel.

iegik commented 4 years ago

@LazyLahtak thanks for response! I'll definitely add sortIconComponent to the TableHeaderRow and try to do same with Material-UI and Bootstrap 3.