chore: use react-popper 2.x in bootstrap4 packages (permits React 18 support)

DevExpress / devextreme-reactive

Business React components for Bootstrap and Material-UI

https://devexpress.github.io/devextreme-reactive/

Other

2.07k stars 376 forks source link

chore: use react-popper 2.x in bootstrap4 packages (permits React 18 support) #3642

Closed glsignal closed 1 year ago

glsignal commented 1 year ago

Hi there!

With React 18 having been available for some time now, one thing holding back an upgrade is the version of Popper in use in the bootstrap4 packages here (since popper 1.x only declares compatibility with up to React 17).

Since Popper 2.x is both compatible with React 18 and still exposes the render-props for compatibility with the existing class-based components in here, is it possible / reasonable to update the package to the 2.x line?

VasilyStrelyaev commented 1 year ago

@glsignal, thank you for your contribution! I have added several commits to this pull request and now I'm merging it. The changes introduced in this PR will be released with the next minor update.

glsignal commented 1 year ago

Thank you for taking the time (and extra changes) to integrate this! It's a big help 🙂