DevExpress / testcafe-browser-provider-browserstack

This is the BrowserStack browser provider plugin for TestCafe.
https://testcafe.io
MIT License
86 stars 65 forks source link

Provider is not fully compatible with the latest Firefox & geckodriver #64

Closed AndreyBelym closed 1 year ago

AndreyBelym commented 5 years ago

The latest geckodriver dropped compatibility with the legacy JsonWireProtocol WebDriver spec and its HTTP endpoints. Geckodriver now supports only endpoints described in the W3C Web Driver spec.

The provider relies on the legacy endpoints in some functionality (maximizing & resizing windows), so we need to update it to restore full compatibility with the latest Firefox from BrowserStack.

ljowen commented 5 years ago

I'm receiving the following error on any firefox > 58.0

ERROR Was unable to open the browser "browserstack:firefox@59.0:OS X High Sierra" due to error.

Error: API error undefined: undefined
    at /node_modules/testcafe-browser-provider-browserstack/lib/backends/automate.js:129:42

Is this related or should I open a new issue?

Lukas-Kullmann commented 5 years ago

@AndreyBelym is there any progress on this?

AndreyBelym commented 5 years ago

@ljowen, it should be fixed in https://github.com/DevExpress/testcafe-browser-provider-browserstack/commit/fb65abb578ed9680cccc36e8a979301181b6d85f. Please ensure that you use the latest (1.8.0) version of testcafe-browser-provider-browserstack and create a new issue if you can reproduce the problem with it.

@Lukas-Kullmann, it needs a fair amount of work to be done. We need to implement alternative API endpoints for Firefox.

Lukas-Kullmann commented 5 years ago

Thanks for the response, @AndreyBelym!

I would love to help, but I don't know how you would envision such a feature. Would you try the Web Driver endpoints and fall back to JsonWire endpoints if those are not available? Or would you do a browser switch?

By the way: I am facing the same problem as @ljowen with v1.8 and Firefox > 58. Just the error message is different (404 response since the endpoint is not available).

Lukas-Kullmann commented 5 years ago

For me, it seems to be working again. Tried Firefox 60 and 65 on Windows 10.

AlexSkorkin commented 5 years ago

Thank you for the update, @Lukas-Kullmann

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity for a long period. It will be closed and archived if no further activity occurs. However, we may return to this issue in the future. If it still affects you or you have any additional information regarding it, please leave a comment and we will keep it open.

github-actions[bot] commented 1 year ago

We're closing this issue after a prolonged period of inactivity. If it still affects you, please add a comment to this issue with up-to-date information. Thank you.