search

DevExpress / testcafe-browser-provider-electron

This is the Electron browser provider plugin for TestCafe.
https://testcafe.io
MIT License
49 stars 30 forks source link

Made '--debug-brk' parameter optional to be able run testcafe on Electron > 19 #92

Closed lenchvolodymyr closed 1 year ago

lenchvolodymyr commented 2 years ago

--debug-brk was deprecated since nodejs 7.7.0 and in electron 1.7.4 was added a support for --inspect. In Electron 19 --debug-brk was supressed and no longer works, which leads to an error: "Unable to connect".

I added a new option enableDebug that allows using an old parameter --debug-brk for Electron < 1.7.4 and use --inspect by default for newer Electron versions.

Related issue: #90

github-actions[bot] commented 2 years ago

Thank you for your contribution to TestCafe. We will review this PR.

AndreyBelym commented 1 year ago

Hi @lenchvolodymyr! Thank you for your contribution. I discussed your PR with the team and we decided we should drop supporting older Electron versions that use the --debug-brk switch. This way there is no need for an additional option in the config. Please let me know if you are interested in reworking your PR. Otherwise, team members can do it in the next several weeks.

lenchvolodymyr commented 1 year ago

Hi @AndreyBelym , this even better:

we decided we should drop supporting older Electron versions

I'll update PR soon

lenchvolodymyr commented 1 year ago

@AndreyBelym it's done

miherlosev commented 1 year ago

Hi @lenchvolodymyr,

Thank you for your work. We will review it.