search

DevExpress / testcafe-browser-provider-saucelabs

This is the Sauce Labs browser provider plugin for TestCafe.
https://devexpress.github.io/testcafe/
MIT License
32 stars 41 forks source link

Implement browser provider #1

Closed AndreyBelym closed 8 years ago

AndreyBelym commented 8 years ago

\cc @inikulin @VasilyStrelyaev

inikulin commented 8 years ago

\r-

VasilyStrelyaev commented 8 years ago

all texts are in the generator, so seems to be nothing to review here for me

AndreyBelym commented 8 years ago

Secret variables are not passed to PRs by TravisCI. It means if we need to use functional tests, we need to setup the buildbot for this repository. I've asked @AlexanderMoskovkin about how to do this.

inikulin commented 8 years ago

Are you sure about it? I wonder how our CI recipe will look like then?

AlexanderMoskovkin commented 8 years ago

Yes, you can't use these variables in builds , triggered by pull requests from another repository (proof). It possible to use them just for pull requests inside a repository (from another branch) and for pushes in any branch. It's the main reason why we've created testcafe-build-bot

AndreyBelym commented 8 years ago

If we want to get rid of mocking, we must pass SauceLabs username and access key to the provider. The most fashionable way is to use secret environment variables, but TravisCI doesn't permit to use them in PRs from forks for security reasons. So there is options:

  1. Use simple environment vars. Drawbacks: access key will be stored as a plaintext in .travis.yml, or will be displayed in build log.
  2. Do not use forks for feature branches, create them in DevExpress/ repository.
  3. Use the buildbot, which will create a branch for each PR and merge it inside its fork, and run tests here. The issue with secret vars is the reason why @AlexanderMoskovkin developed the buildbot. From what I know it won't require code/travis configuration changes, except from disabling TravisCI builds for buildbot temporary branches: https://github.com/DevExpress/testcafe/blob/master/.travis.yml#L24
inikulin commented 8 years ago

Ok, let's use build bot for this repo. Regarding recipe - suggest using hidden vars, once we'll have bot released we can suggest using

testcafe-build-bot commented 8 years ago

:x: Tests for the commit 39d57b135f426589691320966b9bc9541382f5a8 have failed. See details.

AndreyBelym commented 8 years ago

@testcafe-build-bot \retest

testcafe-build-bot commented 8 years ago

:x: Tests for the commit a35bf5838d9cde840acd093331ce57e00cd0bb89 have failed. See details.

testcafe-build-bot commented 8 years ago

:white_check_mark: Tests for the commit a35bf5838d9cde840acd093331ce57e00cd0bb89 have passed. See details.

testcafe-build-bot commented 8 years ago

:white_check_mark: Tests for the commit ea3b0cc42d4329fe178b5f573bb371873503eba8 have passed. See details.

testcafe-build-bot commented 8 years ago

:x: Tests for the commit b66b48167eaa51a34a7f611f539784676497cade have failed. See details.

testcafe-build-bot commented 8 years ago

:x: Tests for the commit 0b014a6639f5f7200e4d93ebccef28a2e7d66b37 have failed. See details.

testcafe-build-bot commented 8 years ago

:x: Tests for the commit b1357104df24121e7da817eedbad1d52998cf57d have failed. See details.

AndreyBelym commented 8 years ago

@testcafe-build-bot \retest

testcafe-build-bot commented 8 years ago

:x: Tests for the commit b1357104df24121e7da817eedbad1d52998cf57d have failed. See details.

testcafe-build-bot commented 8 years ago

:x: Tests for the commit b1357104df24121e7da817eedbad1d52998cf57d have failed. See details.

testcafe-build-bot commented 8 years ago

:white_check_mark: Tests for the commit b1357104df24121e7da817eedbad1d52998cf57d have passed. See details.

testcafe-build-bot commented 8 years ago

:white_check_mark: Tests for the commit c7130da780c4001f0e0c1be8f487fa5036dbce49 have passed. See details.

testcafe-build-bot commented 8 years ago

:white_check_mark: Tests for the commit e3a1b6cc201534febac538c1c330465f05def9db have passed. See details.

testcafe-build-bot commented 8 years ago

:x: Tests for the commit 165cc4c0598ba0ddb0ba34c45ae91d94ec990d91 have failed. See details.

testcafe-build-bot commented 8 years ago

:x: Tests for the commit 5fb7f7cd08e4c152937ea6f6b88ca57c49c6b1fa have failed. See details.

testcafe-build-bot commented 8 years ago

:white_check_mark: Tests for the commit ca174bc83a99454d94da347a8fc2a6a7b40b918e have passed. See details.

testcafe-build-bot commented 8 years ago

:white_check_mark: Tests for the commit 0d6e4e7dbc395d90552514adc6d3920ad25859ab have passed. See details.

AndreyBelym commented 8 years ago

FPR

inikulin commented 8 years ago

Overall - lgtm

testcafe-build-bot commented 8 years ago

:white_check_mark: Tests for the commit ab8189155f01a71b7c234efe635f84bc36a18fc3 have passed. See details.

AndreyBelym commented 8 years ago

FPR

testcafe-build-bot commented 8 years ago

:x: Tests for the commit 8b7be2fbcf51cf4a9b5701535a2a209e77cf1e1a have failed. See details.

testcafe-build-bot commented 8 years ago

:white_check_mark: Tests for the commit 8b7be2fbcf51cf4a9b5701535a2a209e77cf1e1a have passed. See details.

inikulin commented 8 years ago

lgtm

inikulin commented 8 years ago

ping @VasilyStrelyaev

VasilyStrelyaev commented 8 years ago

\r-

inikulin commented 8 years ago

lgtm

VasilyStrelyaev commented 8 years ago

lgtm

testcafe-build-bot commented 8 years ago

:x: Tests for the commit cb60a5833e70605c38c18dc86ef2277679e35d32 have failed. See details.

testcafe-build-bot commented 8 years ago

:white_check_mark: Tests for the commit 328c8572b47b0b7f15c50a884c0d2a635c418e00 have passed. See details.