search

DevExpress / testcafe-browser-provider-saucelabs

This is the Sauce Labs browser provider plugin for TestCafe.
https://devexpress.github.io/testcafe/
MIT License
31 stars 41 forks source link

Allow to provide additional job options as JSON. #24

Closed fpoppinga closed 5 years ago

fpoppinga commented 6 years ago

I think this feature should be merged to the main project.

@madmod, if you don't agree, please close.

testcafe-build-bot commented 6 years ago

:x: Tests for the commit a9f481abab6da67f172289719cf99838d71944ac have failed. See details:

AndreyBelym commented 6 years ago

Hi @fpoppinga, thanks for the excellent job! Hower, I think that it would be very inconvenient to serialize options as JSON, and properly escape them to store in the environment variable. I'm sure that it will be hard to handle this using only command line tools, and you'll need to write a separate script for doing this.

So I suggest to rename the environment variable to SAUCE_CONFIG_PATH, and use it to pass the filename of the file with additional options which can be retrieved by just calliing require('SAUCE_CONFIG_PATH').

fpoppinga commented 6 years ago

@AndreyBelym, well the only work I did so far was creating this PR from @madmod's Fork.

I'll rebase this and adapt the idea you proposed.