Adding SAUCE_SCREEN_RESOLUTION to set browser resolution

DevExpress / testcafe-browser-provider-saucelabs

This is the Sauce Labs browser provider plugin for TestCafe.

https://devexpress.github.io/testcafe/

MIT License

31 stars 41 forks source link

Closed ungb closed 5 years ago

ungb commented 5 years ago

Currently been trying to set resolution via SAUCE_CONFIG_PATH. debugging into it and looking at https://github.com/AlexanderMoskovkin/saucelabs-connector/blob/master/src/index.js#L108 this isn't the correct place to set configurations like screen resolution.

After adding SAUCE_SCREEN_RESOLUTION locally I saw this working.

when I ran export SAUCE_SCREEN_RESOLUTION=2560x1600 with a example test I got the following browser:

without (defaults to 1024x768):

ungb commented 5 years ago

@AndreyBelym can you review? it doesn't seem like I can add reviewers 😅 .

testcafe-build-bot commented 5 years ago

:white_check_mark: Tests for the commit 9db5c9712d36c4a2f5e1e87ada39b7d5d8fabc2d have passed. See details:

AndreyBelym commented 5 years ago

Thank you for your contribution, I will publish testcafe-browser-provider-saucelabs@1.6.0 today.

testcafe-build-bot commented 5 years ago

:x: Tests for the commit 2ba9809a892aa2d94bf279413c0154b3ec0923fa have failed. See details:

testcafe-build-bot commented 5 years ago

:white_check_mark: Tests for the commit b4c0fb1ea044b6233784e587a46a567d2e268ef8 have passed. See details:

ungb commented 5 years ago

Thanks!